Remove useless _RADIUSAttrPacketListField class #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was useless since PacketListField does the job, moreover it was buggy and could cause Scapy to go in a infinite loop. Test case added.
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 85.15% 85.17% +0.01%
==========================================
Files 174 174
Lines 40162 40149 -13
==========================================
- Hits 34201 34195 -6
+ Misses 5961 5954 -7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was useless since PacketListField does the job, moreover it
was buggy and could cause Scapy to go in a infinite loop. Test case
added.
Fixes #1407.